Add support for additional libraries in the Estimator #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiaya
reviewed
Nov 19, 2018
|
|
||
| def test_source_dirs(sagemaker_session, tmpdir): | ||
| source_dir = os.path.join(DATA_DIR, 'pytorch_source_dirs') | ||
| lib = os.path.join(str(tmpdir), 'alexa.py') |
Contributor
There was a problem hiding this comment.
any reason not to put it in a separate directory?
i think it would be closer to a real life use case.
Contributor
Author
There was a problem hiding this comment.
source dir is under test/data and alexa.py is under /tmp. We about thought about the same use case =)
tests/integ/test_source_dirs.py
Outdated
|
|
||
| predict_response = predictor.predict([24]) | ||
|
|
||
| assert predict_response == [24] |
Contributor
There was a problem hiding this comment.
why not make to return 42?
owen-t
previously approved these changes
Nov 19, 2018
src/sagemaker/chainer/README.rst
Outdated
| other training source code dependencies including the entry point | ||
| file. Structure within this directory will be preserved when training | ||
| on SageMaker. | ||
| - ``lib_dirs (list[str])`` A list of paths to directories (absolute or relative) with |
Contributor
There was a problem hiding this comment.
We may want to call this libs as the entries do not need to be directories.
Contributor
Author
There was a problem hiding this comment.
Renaming it to dependencies.
nadiaya
previously approved these changes
Nov 19, 2018
iquintero
reviewed
Nov 19, 2018
src/sagemaker/chainer/README.rst
Outdated
| instead. Example: | ||
|
|
||
| The following call | ||
| >>> Estimator(entry_point='train.py', lib_dirs=['my/libs/common', 'virtual-env']) |
Contributor
There was a problem hiding this comment.
This should be Chainer() not Estimator() Applies to the other ones as well.
nadiaya
previously approved these changes
Nov 19, 2018
owen-t
previously approved these changes
Nov 19, 2018
nadiaya
previously approved these changes
Nov 19, 2018
nadiaya
reviewed
Nov 19, 2018
tests/integ/test_source_dirs.py
Outdated
| from tests.integ import DATA_DIR, PYTHON_VERSION | ||
|
|
||
|
|
||
| def test_source_dirs(sagemaker_session, tmpdir, sagemaker_local_session): |
Contributor
There was a problem hiding this comment.
Can you remove sagemaker_session?
nadiaya
previously approved these changes
Nov 19, 2018
nadiaya
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Introduces the following argument in the Estimator and Model classes.
**dependencies** (list[str])A list of paths to directories (absolute or relative) withany additional libraries that will be exported to the container (default: []).
The library folders will be copied to SageMaker in the same folder where the entrypoint is copied.
If the
source_dirpoints to S3, code will be uploaded and the S3 location will be usedinstead. Example:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.